dcapwell commented on code in PR #4044: URL: https://github.com/apache/cassandra/pull/4044#discussion_r2032084956
########## test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java: ########## @@ -722,27 +939,9 @@ private static void validateAnyOrder(ImmutableUniqueList<Symbol> columns, Set<Ro var unexpected = Sets.difference(actual, expected); var missing = Sets.difference(expected, actual); StringBuilder sb = null; Review Comment: 🤷 this is test code and majority of the perf is on C* handling of the statements, and the models are almost nothing; so could allocate eagerly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org