dcapwell commented on code in PR #4044:
URL: https://github.com/apache/cassandra/pull/4044#discussion_r2033602739
##########
test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java:
##########
@@ -191,6 +209,157 @@ private void indexRowColumn(TreeMap<ByteBuffer,
List<PrimaryKey>> index, boolean
public void update(Mutation mutation)
{
if (!shouldApply(mutation)) return;
+ updateInternal(mutation);
+ }
+
+ public void updateAndValidate(ByteBuffer[][] actual, Mutation mutation)
Review Comment:
for the most part yes... i can look to unify i guess, when not focused on
CAS it was always cleaner to just do `update(mutation)` but that could also
just overload and call this....
i was trying to limit the usage of this method only to CAS as we don't
return stuff like rows impacted like SQL does... i personally like limiting the
domain of allowed input, which is all this method is trying to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
