belliottsmith commented on code in PR #4073:
URL: https://github.com/apache/cassandra/pull/4073#discussion_r2036130904
##########
src/java/org/apache/cassandra/net/Verb.java:
##########
@@ -350,15 +350,14 @@ public enum Verb
ACCORD_GET_LATEST_DEPS_REQ (151, P2, readTimeout, IMMEDIATE,
() -> accordEmbedded(LatestDepsSerializers.request),
AccordService::requestHandlerOrNoop, ACCORD_GET_LATEST_DEPS_RSP),
ACCORD_GET_MAX_CONFLICT_RSP (152, P2, readTimeout, IMMEDIATE,
() -> accordEmbedded(GetMaxConflictSerializers.reply),
AccordService::responseHandlerOrNoop
),
ACCORD_GET_MAX_CONFLICT_REQ (153, P2, readTimeout, IMMEDIATE,
() -> accordEmbedded(GetMaxConflictSerializers.request),
AccordService::requestHandlerOrNoop, ACCORD_GET_MAX_CONFLICT_RSP),
- ACCORD_GET_DURABLE_BEFORE_RSP (154, P2, readTimeout, IMMEDIATE,
() -> accordEmbedded(GetDurableBeforeSerializers.reply),
AccordService::responseHandlerOrNoop
),
- ACCORD_GET_DURABLE_BEFORE_REQ (155, P2, readTimeout, IMMEDIATE,
() -> accordEmbedded(GetDurableBeforeSerializers.request),
AccordService::requestHandlerOrNoop, ACCORD_GET_DURABLE_BEFORE_RSP
),
+ ACCORD_GET_DURABLE_BEFORE_RSP (154, P2, readTimeout, MISC,
() -> accordEmbedded(GetDurableBeforeSerializers.reply),
AccordService::responseHandlerOrNoop
),
+ ACCORD_GET_DURABLE_BEFORE_REQ (155, P2, readTimeout, MISC,
() -> accordEmbedded(GetDurableBeforeSerializers.request),
AccordService::requestHandlerOrNoop, ACCORD_GET_DURABLE_BEFORE_RSP
),
Review Comment:
While investigating I saw a lot of dropped messages I couldn't explain, so I
looked for possible handlers that should not be executed on the IMMEDIATE
stage. This one is probably fine to be honest as it's non-blocking, but it
isn't sent to the any `CommandStore` for processing so the processing would be
done on the netty event loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
