bbotella commented on code in PR #213:
URL: https://github.com/apache/cassandra-sidecar/pull/213#discussion_r2035891235
##########
server/src/main/java/org/apache/cassandra/sidecar/cdc/CdcConfigImpl.java:
##########
@@ -179,7 +179,7 @@ public MinuteBoundConfiguration watermarkWindow()
{
// this prop sets the maximum duration age accepted by CDC, any
mutations with write timestamps older than
// the watermark window will be dropped with log message "Exclude the
update due to out of the allowed time window."
- return new
MinuteBoundConfiguration(getInt(ConfigKeys.WATERMARK_SECONDS.lowcaseName,
DEFAULT_WATERMARK_WINDOW), TimeUnit.SECONDS);
+ return new
MinuteBoundConfiguration(getInt(ConfigKeys.WATERMARK_SECONDS.lowcaseName,
DEFAULT_WATERMARK_WINDOW) / 60, TimeUnit.MINUTES);
Review Comment:
Should we change the resolution to Seconds instead? What if someone
configures 30 seconds for the watermark? That integer would be truncated to
zero right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
