belliottsmith commented on code in PR #184:
URL: https://github.com/apache/cassandra-accord/pull/184#discussion_r2039470825
##########
accord-core/src/main/java/accord/utils/async/AsyncChains.java:
##########
@@ -253,8 +415,37 @@ public static abstract class FlatMap<I, O> extends Link<I,
O> implements Functio
@Override
public void accept(I i, Throwable throwable)
{
- if (throwable != null) next.accept(null, throwable);
- else apply(i).begin(next);
+ try
+ {
+ if (throwable != null) next.accept(null, throwable);
+ else apply(i).begin(next);
+ }
+ catch (Throwable t)
+ {
+ throw t;
+ }
+ }
+ }
+
+ private static abstract class DebugFlatMap<I, O> extends Link.Debug<I, O>
implements Function<I, AsyncChain<O>>
Review Comment:
similarly: wouldn't it be better to extend `FlatMap` since it has more
bespoke logic we may modify in future and want to inherit any changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
