bereng commented on code in PR #275: URL: https://github.com/apache/cassandra-dtest/pull/275#discussion_r2041536141
########## dtest_setup.py: ########## @@ -439,7 +440,7 @@ def init_default_config(self): phi_values = {'phi_convict_threshold': 5} # enable read time tracking of repaired data between replicas by default - if self.cluster.version() >= '4': + if self.cluster.cassandra_version() >= '4': Review Comment: I am obviously missing what is the difference of comparing against a version number and a `LooseVersion`. Aren't you trying to change behavior depending on the 'embedded' underlying C* versions instead of the 'product' version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org