bereng commented on code in PR #3917:
URL: https://github.com/apache/cassandra/pull/3917#discussion_r2042007900
##########
src/java/org/apache/cassandra/cql3/QueryProcessor.java:
##########
@@ -101,6 +102,12 @@ public class QueryProcessor implements QueryHandler
// counters. Callers of processStatement are responsible for correctly
notifying metrics
public static final CQLMetrics metrics = new CQLMetrics();
+ // Paging size to use when preloading prepared statements.
+ public static final int PRELOAD_PREPARED_STATEMENTS_FETCH_SIZE = 5000;
+
+ // Maximum number of prepared statements to preload from prepared
statement cache.
+ public static final int PRELOAD_PREPARED_STATEMENTS_MAX = 1_000_000;
Review Comment:
Thinking about it we don't need to come up with this new limit. We already
have a limit on the cache size in MB. Once you hit that it makes no sense to
just be trashing the cache. So just drop this and monitor cache instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
