dcapwell commented on code in PR #4081:
URL: https://github.com/apache/cassandra/pull/4081#discussion_r2044978456


##########
test/distributed/org/apache/cassandra/distributed/test/cql3/StatefulASTBase.java:
##########
@@ -496,11 +500,35 @@ protected ByteBuffer[][] executeQuery(IInstance instance, 
int fetchSize, Consist
                                  .findAny()
                                  .get();
                 ss.setHost(host);
-                ResultSet result = session.execute(ss);
+                ResultSet result;
+                try
+                {
+                    result = session.execute(ss);
+                }
+                catch (ReadFailureException t)
+                {
+                    throw new AssertionError("failed from=" + 
Maps.transformValues(t.getFailuresMap(), BaseState::safeErrorCode), t);

Review Comment:
   i checked, `getFailuresMap` is defined in each class and not a base type, so 
do need to duplicate; this line doesn't compile if i do `catch 
(ReadFailureException | WriteFailureException t)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to