nizhikov commented on code in PR #4066:
URL: https://github.com/apache/cassandra/pull/4066#discussion_r2045355147


##########
src/java/org/apache/cassandra/utils/logging/LogbackLoggingSupport.java:
##########
@@ -105,10 +100,9 @@ public void setLoggingLevel(String classQualifier, String 
rawLevel) throws Excep
         // if both classQualifier and rawLevel are empty, reload from 
configuration
         if (StringUtils.isBlank(classQualifier) && 
StringUtils.isBlank(rawLevel))
         {
-            JMXConfiguratorMBean jmxConfiguratorMBean = 
JMX.newMBeanProxy(ManagementFactory.getPlatformMBeanServer(),
-                                                                          new 
ObjectName("ch.qos.logback.classic:Name=default,Type=ch.qos.logback.classic.jmx.JMXConfigurator"),

Review Comment:
   Hello, @smiklosovic 
   
   Thanks for the feedback.
   
   Yes, `JMXConfigurator` removed from loback.
   Please, take a look into https://github.com/qos-ch/logback/commit/fa3de69304
   



##########
src/java/org/apache/cassandra/utils/logging/LogbackLoggingSupport.java:
##########
@@ -105,10 +100,9 @@ public void setLoggingLevel(String classQualifier, String 
rawLevel) throws Excep
         // if both classQualifier and rawLevel are empty, reload from 
configuration
         if (StringUtils.isBlank(classQualifier) && 
StringUtils.isBlank(rawLevel))
         {
-            JMXConfiguratorMBean jmxConfiguratorMBean = 
JMX.newMBeanProxy(ManagementFactory.getPlatformMBeanServer(),
-                                                                          new 
ObjectName("ch.qos.logback.classic:Name=default,Type=ch.qos.logback.classic.jmx.JMXConfigurator"),

Review Comment:
   Hello, @smiklosovic 
   
   Thanks for the feedback.
   
   Yes, `JMXConfigurator` removed from logback.
   Please, take a look into https://github.com/qos-ch/logback/commit/fa3de69304
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to