dcapwell commented on code in PR #4087: URL: https://github.com/apache/cassandra/pull/4087#discussion_r2047825576
########## test/unit/org/apache/cassandra/db/compaction/unified/ControllerTest.java: ########## @@ -121,6 +121,50 @@ public void testValidateOptionsIntegers() testValidateOptions(true); } + @Test + public void testValidateOptionsInvalidTargetSSTableSize() + { + //Test 1: TARGET_SSTABLE_SIZE_OPTION = 12E899, the value reported in CASSANDRA-20398 + try { Review Comment: Cassandra's style doesn't match std java style, `{` are on new lines by themself. If you did that by hand, just keep in mind you need to do the cassandra style (see https://cassandra.apache.org/_/development/code_style.html). If your ide did this, then you should rebuild your IDE configs from `ant`. If you use Inteillij, then `ant generate-idea-files` will setup intelij to "do the right thing" most of the time for this project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org