absurdfarce commented on code in PR #2036:
URL:
https://github.com/apache/cassandra-java-driver/pull/2036#discussion_r2048227807
##########
core/src/main/java/com/datastax/oss/driver/internal/core/context/StartupOptionsBuilder.java:
##########
@@ -142,4 +151,14 @@ protected String getDriverName() {
protected String getDriverVersion() {
return Session.OSS_DRIVER_COORDINATES.getVersion().toString();
}
+
+ private String localDc(DriverExecutionProfile profile) {
+ String dc = context.getLocalDatacenter(profile.getName()); // DC set
programmatically
+ if (dc == null &&
profile.isDefined(DefaultDriverOption.LOAD_BALANCING_LOCAL_DATACENTER)) {
+ dc =
+ profile.getString(
+ DefaultDriverOption.LOAD_BALANCING_LOCAL_DATACENTER); // DC from
configuration
+ }
+ return dc;
+ }
Review Comment:
Okay, as I look at this again you're right, there's something of a
bifurcation here already. The entries returned by
DefaultDriverContext.buildStartupOptions() are more static key/value pairs,
mostly (exclusively?) pairs that were used by Insights. Nearly all of those
should be removed as part of
[CASSJAVA-73](https://issues.apache.org/jira/browse/CASSJAVA-73); driver name
and version will stay but the rest should disappear.
So how _should_ we format this data? That question is still under
discussion in CASSJAVA-92... we probably need to settle on what the data should
look like and then adjust this impl accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
