ribaraka opened a new pull request, #1882: URL: https://github.com/apache/cassandra-gocql-driver/pull/1882
Closes #1290 The previous design allowed modifying Session properties through setters. This added unnecessary overhead, as a mutex had to be acquired for every query execution. Additionally, as demonstrated in [#1473](https://github.com/apache/cassandra-gocql-driver/issues/1473) this mutability could lead to race conditions. By making Session immutable, we: 1. Eliminate race condition. 1. Eliminate the performance overhead of mutex acquisition 2. Simplify the concurrency model 3. Making cleaner configuration This PR removing those setters and eliminating the need for the mutex. Configuration of refactored properties (i.e. consistency, trace etc.) is now handled at session creation through `ClusterConfig` and/or at execution time through **per-query** methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
