aweisberg commented on code in PR #4104: URL: https://github.com/apache/cassandra/pull/4104#discussion_r2052804747
########## src/java/org/apache/cassandra/db/filter/RowFilter.java: ########## @@ -172,15 +173,21 @@ public boolean isStrict() */ public boolean isMutableIntersection() { - int count = 0; + IntHashSet columns = null; for (Expression e : expressions) { if (e.column.isStatic() && expressions.size() > 1) return true; if (!e.column.isPrimaryKeyColumn()) - if (++count > 1) + { + if (columns == null) + columns = new IntHashSet(expressions.size(), 0.9f); Review Comment: Why `0.9f` for an open address hash able which I assume does linear probing? The default is 0.65. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org