krummas commented on code in PR #4099:
URL: https://github.com/apache/cassandra/pull/4099#discussion_r2053906546
##########
src/java/org/apache/cassandra/db/LivenessInfo.java:
##########
@@ -220,7 +220,11 @@ public boolean supersedes(LivenessInfo other)
if (isExpired() ^ other.isExpired())
return isExpired();
if (isExpiring() == other.isExpiring())
- return localExpirationTime() > other.localExpirationTime();
+ {
+ return localExpirationTime() > other.localExpirationTime() ||
+ (localExpirationTime() == other.localExpirationTime() &&
ttl() < other.ttl());
Review Comment:
nit; maybe update the comment to this method about the ttls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
