jaydeepkumar1984 commented on code in PR #4126:
URL: https://github.com/apache/cassandra/pull/4126#discussion_r2065117013
##########
src/java/org/apache/cassandra/repair/autorepair/AutoRepair.java:
##########
@@ -223,7 +224,11 @@ public void repair(AutoRepairConfig.RepairType repairType)
}
// Separate out the keyspaces and tables to repair based on
their priority, with each repair plan representing a uniquely occuring priority.
- List<PrioritizedRepairPlan> repairPlans =
PrioritizedRepairPlan.build(keyspacesAndTablesToRepair, repairType,
shuffleFunc);
+ List<PrioritizedRepairPlan> repairPlans =
PrioritizedRepairPlan.build(keyspacesAndTablesToRepair, repairType,
shuffleFunc, primaryRangeOnly);
+
+ int keyspaceRepairPlansSofar = 0;
Review Comment:
It is cumbersome to identify if a keyspace has been completely repaired or
not, due to our priority-based allotment. In most cases, when priority is not
set, one _keyspace_=one _keyspaceRepairPlans_. I agree that it is hard for end
users to differentiate between keyspace vs. keyspaceRepairPlans if priority is
set, but in the beginning we can target accuracy for folks that have no
priority set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
