iamaleksey commented on code in PR #4106:
URL: https://github.com/apache/cassandra/pull/4106#discussion_r2068453915
##########
src/java/org/apache/cassandra/replication/CoordinatorLogId.java:
##########
@@ -142,5 +148,12 @@ public long serializedSize(CoordinatorLogId logId, int
version)
{
return TypeSizes.sizeof(logId.hostId) +
TypeSizes.sizeof(logId.hostLogId);
}
- };
+
+ public long serializedSize(long logId, int version)
+ {
+ return TypeSizes.sizeof(logId);
+ }
+ }
+
+ static final Serializer serializer = new Serializer();
Review Comment:
Because I added `public void serialize(long logId, DataOutputPlus out, int
version)` and `public long serializedSize(long logId, int version)` to it and
needed a way to refer to them. (And the reason I added them instead of simply
writing a long is to centralise this logic in case we change the format in the
future and forget to update a part of it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
