dcapwell commented on code in PR #4131:
URL: https://github.com/apache/cassandra/pull/4131#discussion_r2069024661


##########
.build/build-accord.xml:
##########
@@ -27,10 +27,16 @@
         <arg value="publishToMavenLocal" />
         <arg value="-x" />
         <arg value="test" />
-        <!-- since so much development is done from this hook, by adding 
checkstyle and rat will avoid issues earlier -->
+        <!-- Disable rat/checkstyle as C*'s logic will include the accord 
source -->
+        <arg value="-x" />
         <arg value="rat" />
+        <arg value="-x" />
         <arg value="checkstyleMain" />
+        <arg value="-x" />
         <arg value="checkstyleTest" />
+        <arg value="-x" />
+        <arg value="javadoc" />

Review Comment:
   a wall of text gets generated w/e we build due to javadoc warnings.  We 
don't consume this jar so figure best to disable for the moment.
   
   When it comes to releasing `cassandra-all` we need to figure out how accord 
fits in, as `cassandra-all` depends on this jar (and users would like javadocs)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to