dkropachev commented on PR #1758: URL: https://github.com/apache/cassandra-gocql-driver/pull/1758#issuecomment-2844700619
> LGTM. Please, make it up to date, make the notation to the CHANGELOG.md, and change the commit message according to the CONTRIBUTING.md. The commit message format should be: > > ``` > <short description> > > <reason why the change is needed> > > Patch by <authors>; reviewed by <Reviewers> for CASSGO-##### > ``` > > NIT: We shouldn't add code that we don't add/change, ConnectAddressAndPort() as an example in this case. > > @jameshartig, @joao-r-reis, could we merge it after the update? Don -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
