yifan-c commented on code in PR #189:
URL: https://github.com/apache/cassandra-accord/pull/189#discussion_r2071899614
##########
accord-core/src/test/java/accord/utils/Property.java:
##########
@@ -944,6 +944,19 @@ public CommandsBuilder<State, SystemUnderTest>
addIf(Predicate<State> predicate,
return this;
}
+ @SafeVarargs
+ public final CommandsBuilder<State, SystemUnderTest>
addAllIf(Predicate<State> predicate,
+
Setup<State, SystemUnderTest> first,
+
Setup<State, SystemUnderTest> second,
+
Setup<State, SystemUnderTest>... reset)
Review Comment:
`rest`?
##########
accord-core/src/test/java/accord/utils/Property.java:
##########
@@ -944,6 +944,19 @@ public CommandsBuilder<State, SystemUnderTest>
addIf(Predicate<State> predicate,
return this;
}
+ @SafeVarargs
+ public final CommandsBuilder<State, SystemUnderTest>
addAllIf(Predicate<State> predicate,
Review Comment:
To me, `addAllIf` is hard to understand. My mental model when processing it
reads as
```
if (predicate)
{
first;
second;
rest...;
}
```
So, maybe just `addIf`.
I guess you mean "add all the if statements". Since they are using the same
predicate, it is really one single `if` statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
