michaelsembwever commented on code in PR #790:
URL: https://github.com/apache/cassandra-ccm/pull/790#discussion_r2073344306
##########
ccm:
##########
@@ -24,22 +24,12 @@ import pkg_resources
from six import print_
from ccmlib import common
-from ccmlib.cmds import cluster_cmds, command, node_cmds
+from ccmlib.cmds import cluster_cmds, node_cmds
+from ccmlib.cmds.common import get_command
from ccmlib.remote import (PARAMIKO_IS_AVAILABLE, execute_ccm_remotely,
get_remote_options, get_remote_usage)
-def get_command(kind, cmd):
Review Comment:
does this break compatibility ? would any client be calling this ? (any
client that cannot easily add `from ccmlib.cmds.common import get_command` ?)
if so, we should put in (something like) a deprecated
```
def get_command(kind, cmd):
import ccmlib.cmds.common
return common.get_command(kind, cmd)
```
(`common.get_version_from_build` has a deprecated coding example, not sure
what's idiomatic here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
