frankgh commented on code in PR #4100:
URL: https://github.com/apache/cassandra/pull/4100#discussion_r2073821918
##########
src/java/org/apache/cassandra/service/snapshot/SnapshotManager.java:
##########
@@ -568,18 +570,33 @@ <T> T executeTask(AbstractSnapshotTask<T> task)
private synchronized void prePopulateSnapshots(TakeSnapshotTask task)
{
Map<ColumnFamilyStore, TableSnapshot> snapshotsToCreate =
task.getSnapshotsToCreate();
- for (Map.Entry<ColumnFamilyStore, TableSnapshot> toCreateEntry :
snapshotsToCreate.entrySet())
+ Map<ColumnFamilyStore, TableSnapshot> snapshotsToOverwrite = new
HashMap<>();
Review Comment:
Makes sense, I missed the part in line 572 where `snapshotsToCreate` just
references the task's `snapshotsToCreate`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
