dcapwell commented on code in PR #190: URL: https://github.com/apache/cassandra-accord/pull/190#discussion_r2082370772
########## accord-core/src/main/java/accord/local/DurableBefore.java: ########## @@ -18,26 +18,21 @@ package accord.local; -import java.util.function.BiFunction; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; - import accord.api.RoutingKey; +import accord.primitives.*; import accord.primitives.Status.Durability; -import accord.primitives.AbstractRanges; -import accord.primitives.Participants; -import accord.primitives.TxnId; -import accord.primitives.Unseekables; import accord.utils.Invariants; import accord.utils.PersistentField; import accord.utils.ReducingIntervalMap; import accord.utils.ReducingRangeMap; import accord.utils.async.AsyncResult; import accord.utils.async.AsyncResults; -import static accord.primitives.Status.Durability.MajorityOrInvalidated; -import static accord.primitives.Status.Durability.NotDurable; -import static accord.primitives.Status.Durability.UniversalOrInvalidated; +import javax.annotation.Nonnull; +import javax.annotation.Nullable; +import java.util.function.BiFunction; + +import static accord.primitives.Status.Durability.*; Review Comment: `*` imports, we talked about avoiding these ########## accord-core/src/main/java/accord/local/DurableBefore.java: ########## @@ -18,26 +18,21 @@ package accord.local; -import java.util.function.BiFunction; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; - import accord.api.RoutingKey; +import accord.primitives.*; import accord.primitives.Status.Durability; -import accord.primitives.AbstractRanges; -import accord.primitives.Participants; -import accord.primitives.TxnId; -import accord.primitives.Unseekables; import accord.utils.Invariants; import accord.utils.PersistentField; import accord.utils.ReducingIntervalMap; import accord.utils.ReducingRangeMap; import accord.utils.async.AsyncResult; import accord.utils.async.AsyncResults; -import static accord.primitives.Status.Durability.MajorityOrInvalidated; -import static accord.primitives.Status.Durability.NotDurable; -import static accord.primitives.Status.Durability.UniversalOrInvalidated; +import javax.annotation.Nonnull; +import javax.annotation.Nullable; +import java.util.function.BiFunction; + +import static accord.primitives.Status.Durability.*; Review Comment: `*` imports, we agreed about avoiding these -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
