bdeggleston commented on code in PR #4119: URL: https://github.com/apache/cassandra/pull/4119#discussion_r2085022535
########## src/java/org/apache/cassandra/replication/Offsets.java: ########## Review Comment: I've definitely burned enough time tracking down mysterious invalid state that I got into the habit of making things explicitly immutable. > That said, every time someone adds another Builder to the codebase, a kitten dies somewhere. This is a benefit. Writing a builder is, all things considered, less work than doing the job by hand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
