tolbertam commented on code in PR #4157:
URL: https://github.com/apache/cassandra/pull/4157#discussion_r2093564251
##########
src/java/org/apache/cassandra/repair/autorepair/AutoRepair.java:
##########
@@ -566,4 +569,35 @@ public void progress(String tag, ProgressEvent event)
}
}
}
+
+ public synchronized void shutdownBlocking() throws ExecutionException,
InterruptedException
+ {
+ if (!isSetupDone)
+ {
+ // By default, executors within AutoRepair are not initialized as
the feature is opt-in.
+ // If the AutoRepair has not been set up, then there is no need to
worry about shutting it down
+ return;
+ }
+ if (isShutDown)
+ {
+ throw new IllegalStateException("AutoRepair has already been shut
down");
+ }
Review Comment:
actually, given `HintsService.shutdownBlocking` behaves this way, I see no
harm in leaving it this way. Given the behavior is inconsistent between
different components being shut down, I think there isn't much value in
changing the behavior. Since we already have a relatively clean test run, I'm
going to give +1 so we can get this merged right on in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
