tjons commented on code in PR #1889:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1889#discussion_r2093753860
##########
session.go:
##########
@@ -454,6 +454,10 @@ func (s *Session) Bind(stmt string, b func(q *QueryInfo)
([]interface{}, error))
// Close closes all connections. The session is unusable after this
// operation.
func (s *Session) Close() {
+ // Closing a nil session is a non-event, return.
+ if s == nil {
Review Comment:
It's not a true "bug" in gocql but it's somewhat outside the accepted norm
for Go libraries, particularly low-level ones. If you were reconsidering the
API here, I'd encourage considering how to represent user-error in a way that's
ergonomic to the user. I empathize with the need to ship the next release, and
while I'd handle this differently I respect that the maintainers have their own
priorities.
I tried to find the middle ground approach here: if the library can fail
silently and nondestructively I believe it is best to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
