dcapwell commented on code in PR #792:
URL: https://github.com/apache/cassandra-ccm/pull/792#discussion_r2103190700
##########
ccmlib/node.py:
##########
@@ -789,6 +789,9 @@ def get_launch_bin(self):
def add_custom_launch_arguments(self, args):
pass
+ def __log_dir(self):
+ return '-Dcassandra.logdir=%s' % os.path.join(self.get_path(), 'logs')
Review Comment:
doesn't this need to work on python 3.x? this synatx is 2.7 only right?
##########
ccmlib/node.py:
##########
@@ -789,6 +789,9 @@ def get_launch_bin(self):
def add_custom_launch_arguments(self, args):
pass
+ def __log_dir(self):
+ return '-Dcassandra.logdir=%s' % os.path.join(self.get_path(), 'logs')
Review Comment:
doesn't this need to work on python 3.x? this synatx is 2.7 only right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
