smiklosovic commented on code in PR #4166:
URL: https://github.com/apache/cassandra/pull/4166#discussion_r2106886837
##########
bin/cassandra:
##########
@@ -247,6 +251,8 @@ while true; do
;;
-H)
properties="$properties -XX:HeapDumpPath=$2"
+ # disable automatic heap dump files management as HeapDumpPath was
overridden
+ call_clean_heap_dump_files=
Review Comment:
I declare `call_clean_heap_dump_files=true/0` in this script and here set it
to `false/1` and then compared it in `if` above. I do not like this approach
where we don't set it to anything.
##########
bin/cassandra:
##########
@@ -247,6 +251,8 @@ while true; do
;;
-H)
properties="$properties -XX:HeapDumpPath=$2"
+ # disable automatic heap dump files management as HeapDumpPath was
overridden
+ call_clean_heap_dump_files=
Review Comment:
I would declare `call_clean_heap_dump_files=true/0` in this script and here
set it to `false/1` and then compared it in `if` above. I do not like this
approach where we don't set it to anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
