samueldlightfoot commented on code in PR #4178:
URL: https://github.com/apache/cassandra/pull/4178#discussion_r2108710076


##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -1245,6 +1246,12 @@ public enum DiskAccessMode
         direct
     }
 
+    public enum ScanDiskAccessMode
+    {
+        disk_default,

Review Comment:
   This enum was intended to differentiate scans using the default disk access 
mode (conf.disk_access_mode via the existing dFile handle) from scans requiring 
a new, direct file handle. 
   
   Update: code has now been updated to use DiskAccessMode. I think this 
integrates well with the existing setup.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to