frankgh commented on code in PR #220:
URL: https://github.com/apache/cassandra-sidecar/pull/220#discussion_r2112543384
##########
server/src/main/java/org/apache/cassandra/sidecar/acl/authentication/MutualTlsAuthenticationHandlerFactory.java:
##########
@@ -93,8 +97,7 @@ private MutualTlsAuthenticationHandler createInternal(Vertx
vertx,
CertificateIdentityExtractor certificateIdentityExtractor;
if
(parameters.get(CERTIFICATE_IDENTITY_EXTRACTOR_PARAM_KEY).equalsIgnoreCase(CassandraIdentityExtractor.class.getName()))
{
- certificateIdentityExtractor = new
CassandraIdentityExtractor(identityToRoleCache,
-
accessControlConfiguration.adminIdentities());
+ certificateIdentityExtractor = new
CassandraIdentityExtractor(adminIdentityResolver, identityToRoleCache);
Review Comment:
the `accessControlConfiguration` parameter is no longer used, can we remove
it?
##########
server/src/main/java/org/apache/cassandra/sidecar/acl/AdminIdentityResolver.java:
##########
@@ -33,7 +31,7 @@ public class AdminIdentityResolver
{
private final IdentityToRoleCache identityToRoleCache;
private final SuperUserCache superUserCache;
- private final Set<String> adminIdentities;
+ private final SidecarConfiguration config;
Review Comment:
I think we can just keep a reference to the `AccessControlConfiguration`
here instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
