dkropachev commented on code in PR #1881:
URL: 
https://github.com/apache/cassandra-gocql-driver/pull/1881#discussion_r2114143634


##########
conn_test.go:
##########


Review Comment:
   Sorry for missleading, in current cicd it is run without tags 
https://github.com/apache/cassandra-gocql-driver/blob/05e6036ff1d7d3d8aaacbe6817723e435cad22db/.github/workflows/main.yml#L25-L25
   
   while in this PR it runs with all known tags:
   ```
        go vet --tags "unit all cassandra integration" ./...
   ```
   
   Since this file is tagged 
https://github.com/apache/cassandra-gocql-driver/blob/05e6036ff1d7d3d8aaacbe6817723e435cad22db/conn_test.go#L1-L2
   It is not looked at by `go vet` in current CICD



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to