Mmuzaf commented on code in PR #4037: URL: https://github.com/apache/cassandra/pull/4037#discussion_r2121924559
########## src/java/org/apache/cassandra/hints/HintsService.java: ########## @@ -258,6 +258,17 @@ public long getTotalHintsSize(UUID hostId) return store.getTotalFileSize(); } + /** + * Get the total hints file size of current node + */ + public long getTotalHintsSizeOfNode() + { + return catalog.stores() Review Comment: Didn't we agree that having streams in the hot path is bad? I suppose metrics are one of those cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org