ifesdjeen commented on code in PR #198:
URL: https://github.com/apache/cassandra-accord/pull/198#discussion_r2132269971
##########
accord-core/src/main/java/accord/coordinate/CoordinateEphemeralRead.java:
##########
@@ -65,20 +67,36 @@ public static AsyncResult<Result> coordinate(Node node,
FullRoute<?> route, TxnI
return AsyncResults.failure(mismatch);
Topologies topologies = node.topology().withUnsyncedEpochs(route,
txnId, txnId);
- CoordinateEphemeralRead coordinate = new CoordinateEphemeralRead(node,
topologies, route, txnId, txn);
+ SettableByCallback<Result> result = new SettableByCallback<>();
+ CoordinateEphemeralRead coordinate = new CoordinateEphemeralRead(node,
topologies, route, txnId, txn, result);
+ coordinate.start();
+ return result;
+ }
+
+ public static void coordinate(Node node, FullRoute<?> route, TxnId txnId,
Txn txn, BiConsumer<Result, Throwable> callback)
Review Comment:
should we call this one coordinateAsync maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
