yifan-c commented on code in PR #221:
URL: https://github.com/apache/cassandra-sidecar/pull/221#discussion_r2132613557
##########
server/src/main/java/org/apache/cassandra/sidecar/restore/RestoreJobConsistencyChecker.java:
##########
@@ -100,6 +100,7 @@ public Future<RestoreJobProgress> check(RestoreJob
restoreJob, RestoreJobProgres
RestoreJobProgressCollector collector =
RestoreJobProgressCollectors.create(restoreJob, fetchPolicy);
RestoreRangeStatus successCriteria =
restoreJob.expectedNextRangeStatus();
ConsistencyVerifier verifier =
ConsistencyVerifiers.forConsistencyLevel(restoreJob.consistencyLevel,
restoreJob.localDatacenter);
+ LOGGER.info("Checking restore job progress. jobId={} fetchPolicy={}
successCriteria={}", restoreJob.jobId, fetchPolicy, successCriteria);
Review Comment:
It depends on the client.
In the context of Anayltics, the rate is at most once per second. I am
adding this log message, because it is critical to confirm that client is
requesting the consistency check.
We over-estimate log verbosity in some places but often under-estimate in
many other places. I think this one does not fall into the under-estimate
category.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
