absurdfarce commented on PR #2013: URL: https://github.com/apache/cassandra-java-driver/pull/2013#issuecomment-2963932249
These changes look good @jahstreet , thanks for jumping on this so fast! A local test build seemed to succeed without a problem so I've kicked off a Jenkins build to (a) confirm that we're good and (b) throw all the unit and integration tests at it. I'm cautiously optimistic we've got it this time! As for what I've been running... most of the time I've been using the same [command](https://github.com/apache/cassandra-java-driver/blob/4.19.0/Jenkinsfile-datastax#L121) used by the DataStax Jenkinsfile (`mvn -B -V install -DskipTests -Dmaven.javadoc.skip=true`) but I've been able to reproduce it with the even simpler `mvn clean install -DskipTests=true`. Note that I did _not_ see this failure in my local test builds until I manually added the change to make guava-shaded an optional dependency; prior to that change the only place I saw it was on Jenkins. And I'm pretty sure that's because Jenkins was merging the changes in the PR into the current state of 4.x... which meant the commit making the guava-shaded dependency optional was brought into play. That's just a hypothesis but it seems to fit all the facts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
