ekaterinadimitrova2 commented on code in PR #4196:
URL: https://github.com/apache/cassandra/pull/4196#discussion_r2145913455
##########
src/java/org/apache/cassandra/index/sai/plan/QueryController.java:
##########
@@ -395,15 +407,15 @@ private KeyRangeIterator getTopKRows(List<PrimaryKey>
rawSourceKeys, RowFilter.E
/**
* Create row id iterator from different indexes' on-disk searcher of the
same sstable
*/
- private KeyRangeIterator createRowIdIterator(Pair<Expression,
Collection<SSTableIndex>> indexExpression)
+ private KeyRangeIterator
createRowIdIterator(QueryViewBuilder.QueryExpressionView indexExpression)
{
- List<KeyRangeIterator> subIterators = indexExpression.right
+ List<KeyRangeIterator> subIterators = indexExpression.sstableIndexes
.stream()
.map(index ->
{
try
{
- List<KeyRangeIterator> iterators =
index.search(indexExpression.left, mergeRange, queryContext);
+ List<KeyRangeIterator> iterators =
index.search(indexExpression.expression, mergeRange, queryContext);
// concat the result from multiple
segments for the same index
return
KeyRangeConcatIterator.builder(iterators.size()).add(iterators).build();
Review Comment:
How about a comment or TODO, so the next person working in this area is
aware of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
