jameshartig commented on PR #1886: URL: https://github.com/apache/cassandra-gocql-driver/pull/1886#issuecomment-2974936184
This needs a test. Also, this addresses one of the issues but doesn't address the issue with the control connection querying the local table and getting back the wrong information. See https://github.com/apache/cassandra-gocql-driver/issues/1873#issuecomment-2778506348 for more details. I was going to suggest that we do what that comment suggests and call `refreshRing` from within `setupConn` but that's going to end up causing double hosts lookups on initialization and it will not respect `DisableInitialHostLookup` if that's set. The problem with `setupConn` is that it'll end up overwriting the host information with incorrect info since the local table has wrong information in it. It sounds like other drivers just do a full ring refresh but I don't think we can do that in this case. Should we just be ignoring some information in `addOrUpdate`? @joao-r-reis thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
