sarankk commented on code in PR #225:
URL: https://github.com/apache/cassandra-sidecar/pull/225#discussion_r2151155967


##########
server/src/main/java/org/apache/cassandra/sidecar/acl/authorization/BasicPermissions.java:
##########
@@ -70,9 +70,12 @@ public class BasicPermissions
     public static final Permission READ_SCHEMA = new 
DomainAwarePermission("SCHEMA:READ", CLUSTER_SCOPE);
     public static final Permission READ_SCHEMA_KEYSPACE_SCOPED = new 
DomainAwarePermission("SCHEMA:READ", KEYSPACE_SCOPE);
     public static final Permission READ_GOSSIP = new 
DomainAwarePermission("GOSSIP:READ", CLUSTER_SCOPE);
+    public static final Permission WRITE_GOSSIP = new 
DomainAwarePermission("GOSSIP:WRITE", CLUSTER_SCOPE);

Review Comment:
   How about `GOSSIP:CONTROL` or `GOSSIP:MODIFY`. Similarly we can use for 
Native permission too `NATIVE:CONTROL` or `NATIVE:MODIFY` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to