jameshartig commented on code in PR #1895:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1895#discussion_r2161789622
##########
host_source.go:
##########
@@ -413,8 +414,9 @@ func (h *HostInfo) update(from *HostInfo) {
if h.dataCenter == "" {
h.dataCenter = from.dataCenter
}
- if h.rack == "" {
+ if h.missingRack || h.rack == "" {
Review Comment:
Yeah, I could see that, I was trying to handle filling in the rack if it was
empty but since "" is valid I should remove it.
##########
host_source.go:
##########
@@ -700,8 +747,12 @@ func (r *ringDescriber) getLocalHostInfo() (*HostInfo,
error) {
host, err := r.session.hostInfoFromIter(iter, nil, r.session.cfg.Port)
if err != nil {
+ iter.Close()
Review Comment:
This was just to cleanup the iterator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
