netudima commented on PR #4207: URL: https://github.com/apache/cassandra/pull/4207#issuecomment-2997907956
@hsahu-ksolves123 thank you for the PR. Please find a set of comments below: - Could you please add unit tests to reproduce and cover the original issue. CommitLog is a critical functionality for database correctness, so a manual testing is not enough. - Have you executed the existing CommitLog-related unit tests to ensure that there is no regression caused by the changes? (https://cassandra.apache.org/_/development/testing.html) - Please follow Cassandra code style (https://cassandra.apache.org/_/development/code_style.html), especially the part about braces location - Please clarify if you used any AI tool to prepare the code changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
