belliottsmith commented on code in PR #205:
URL: https://github.com/apache/cassandra-accord/pull/205#discussion_r2164366650
##########
accord-core/src/main/java/accord/local/Commands.java:
##########
@@ -963,6 +1017,12 @@ private static Command purge(Command command, @Nonnull
StoreParticipants newPart
return result;
}
+ private static boolean validateSafeToFastApply(SafeCommandStore safeStore,
SafeCommand safeCommand)
+ {
+ // TODO (now): implement validation!!
+ return true;
Review Comment:
I will aim to get this done before merge, thanks for pointing it out
(though, it should already be covered by existing validation, this would
provide tighter/faster coverage)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
