belliottsmith commented on code in PR #4201:
URL: https://github.com/apache/cassandra/pull/4201#discussion_r2164383474
##########
src/java/org/apache/cassandra/service/accord/interop/AccordInteropRead.java:
##########
@@ -251,7 +280,7 @@ protected AsyncChain<Data> beginRead(SafeCommandStore
safeStore, Timestamp execu
SinglePartitionReadCommand readCommand =
((SinglePartitionReadCommand)command);
TokenKey key = new TokenKey(readCommand.metadata().id,
readCommand.partitionKey().getToken());
if (!execute.contains(key))
- return AsyncChains.success(null);
+ return AsyncChains.success(new LocalReadData(new
ArrayList<>(), readCommand));
Review Comment:
I would prefer to, but I didn't want to modify how LocalReadData behaves,
and it currently modifies itself (rather than constructing a new object with
the new contents)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
