marschall commented on code in PR #329:
URL: https://github.com/apache/cassandra/pull/329#discussion_r2163992655


##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -296,6 +297,13 @@ public static Config loadConfig() throws 
ConfigurationException
             Config.log(config);
         }
 
+        if (config.enable_direct_io_for_read_path)
+        {
+            logger.info("Initializing support for O_DIRECT");
+            if (JavaUtils.parseJavaVersion(System.getProperty("java.version")) 
< 11)

Review Comment:
   Should you also check that a `jdk.unsupported` module is accessible? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to