nvharikrishna commented on code in PR #233:
URL: https://github.com/apache/cassandra-sidecar/pull/233#discussion_r2180493044


##########
client/src/testFixtures/java/org/apache/cassandra/sidecar/client/SidecarClientTest.java:
##########
@@ -1811,6 +1816,90 @@ void testNodeUpdateNative() throws Exception
         });
     }
 
+    @Test
+    public void testLiveMigrationListInstanceFiles() throws 
ExecutionException, InterruptedException, JsonProcessingException

Review Comment:
   done



##########
client/src/main/java/org/apache/cassandra/sidecar/client/SidecarClient.java:
##########
@@ -890,6 +894,38 @@ public <T> CompletableFuture<T> 
executeRequestAsync(RequestContext context)
         return executor.executeRequestAsync(context);
     }
 
+    /**
+     * Gets list of files available at a Cassandra Instance using Sidecar 
during Live Migration.
+     *
+     * @param instance Sidecar instance where the request will be executed
+     * @return a CompletableFuture representing the completion of the operation
+     */
+    public CompletableFuture<InstanceFilesListResponse> 
liveMigrationListInstanceFilesAsync(SidecarInstance instance)
+    {
+        return 
executor.executeRequestAsync(requestBuilder().singleInstanceSelectionPolicy(instance)
+                                                            .request(new 
LiveMigrationListInstanceFilesRequest())
+                                                            .build());
+    }
+
+
+    /**
+     * Downloads requested file {@code reqPath} to the destination file 
provided with param {@code targetFile}
+     * during Live Migration.
+     *
+     * @param instance       the instance where the request will be executed
+     * @param reqPath        instance file path to copy
+     * @param targetFilePath destination file path to save file coming from 
remote
+     * @return a CompletableFuture representing the completion of the operation
+     */
+    public CompletableFuture<Boolean> 
liveMigrationStreamFileAsync(SidecarInstance instance, String reqPath, String 
targetFilePath)

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to