jameshartig commented on code in PR #1898:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1898#discussion_r2181236216
##########
session.go:
##########
@@ -786,7 +786,16 @@ func (s *Session) ExecuteBatchCAS(batch *Batch, dest
...interface{}) (applied bo
// Further scans on the interator must also remember to include
// the applied boolean as the first argument to *Iter.Scan
func (b *Batch) ExecCAS(dest ...interface{}) (applied bool, iter *Iter, err
error) {
- iter = b.session.executeBatch(b, nil)
+ return b.ExecCASContext(nil, dest...)
Review Comment:
The context docs say:
> Do not pass a nil [Context](https://pkg.go.dev/context#Context), even if a
function permits it. Pass [context.TODO](https://pkg.go.dev/context#TODO) if
you are unsure about which Context to use.
We should either pass a TODO or pass context.Background()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
