smiklosovic commented on code in PR #4226:
URL: https://github.com/apache/cassandra/pull/4226#discussion_r2182494965
##########
conf/cassandra-env.sh:
##########
@@ -131,9 +131,11 @@ fi
if [ "x$MAX_HEAP_SIZE" = "x" ] && [ "x$HEAP_NEWSIZE" = "x" -o $USING_G1 -eq 0
]; then
MAX_HEAP_SIZE="$CALCULATED_MAX_HEAP_SIZE"
HEAP_NEWSIZE="$CALCULATED_CMS_HEAP_NEWSIZE"
-elif [ "x$MAX_HEAP_SIZE" = "x" ] || [ "x$HEAP_NEWSIZE" = "x" -a $USING_G1 -ne
0 ]; then
- echo "please set or unset MAX_HEAP_SIZE and HEAP_NEWSIZE in pairs when
using CMS GC (see cassandra-env.sh)"
- exit 1
+elif [ $USING_CMS -eq 0 ]; then
Review Comment:
after changes in bin/nodetool where I parse it from this script, these
changes in particular are not entirely necessary but I like to be explicit
about CMS. So far we operate with logic "if it is not G1 then it is CMS". What
if we go to use yet another GC? Then it would be triggered as well. If we
explicitly say that "when using CMS GC" is the message before we exit, then we
should explicitly check we are using CMS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
