ifesdjeen commented on code in PR #4230:
URL: https://github.com/apache/cassandra/pull/4230#discussion_r2191092976
##########
src/java/org/apache/cassandra/service/accord/AccordJournal.java:
##########
@@ -503,19 +510,26 @@ public void replay(CommandStores commandStores)
ref.key().id.compareTo(prev.id) != 0,
"duplicate key detected %s == %s",
ref.key(), prev);
prev = ref.key();
- AsyncChains.getUnchecked(loader.load(txnId)
- .map(command -> {
- if
(journalTable.shouldIndex(ref.key())
- &&
command.participants() != null
- &&
command.participants().route() != null)
- {
-
ref.segments(segment -> {
-
journalTable.safeNotify(index -> index.update(segment,
ref.key().commandStoreId, txnId, command.participants().route()));
- });
- }
- return command;
- })
- .beginAsResult());
+
+ Throwable rethrow = failures.poll();
+ if (rethrow != null)
+ throw rethrow;
+
+ concurrency.acquireThrowUncheckedOnInterrupt(1);
+ loader.load(txnId)
+ .map(route -> {
Review Comment:
It is, sure; I mean I have done some testing separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
