belliottsmith commented on code in PR #4202: URL: https://github.com/apache/cassandra/pull/4202#discussion_r2192752190
########## src/java/org/apache/cassandra/service/accord/serializers/TopologySerializers.java: ########## @@ -159,4 +167,127 @@ public long serializedSize(Topology topology) return size; } }; + + public static final UnversionedSerializer<Topology> compactTopology = new UnversionedSerializer<>() + { + @Override + public void serialize(Topology topology, DataOutputPlus out) throws IOException + { + out.writeLong(topology.epoch()); + CollectionSerializers.serializeList(topology.staleIds(), out, TopologySerializers.nodeId); + + List<Shard> shards = topology.shards(); + + // need to loop twice; once to collect tables/ranges, and another to save shards + ImmutableUniqueList<TableId> tables; Review Comment: Note, this logic works just as well for the case of duplicate items. You just skip anything already written, that must exist in the map. That is, you do ``` if (null == indexLookup.putIfAbsent(value, indexLookup.size())) out.write(value); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org