dcapwell commented on code in PR #4220:
URL: https://github.com/apache/cassandra/pull/4220#discussion_r2205897212
##########
src/java/org/apache/cassandra/db/ColumnFamilyStore.java:
##########
@@ -2228,6 +2228,12 @@ public void forceMajorCompaction(boolean splitOutput,
int permittedParallelism)
CompactionManager.instance.performMaximal(this, splitOutput,
permittedParallelism);
}
+ @VisibleForTesting
+ public List<Future<?>> submitMajorCompaction(boolean splitOutput, int
permittedParallelism)
Review Comment:
i mostly added this for Caleb as he wanted a AST based test that had async
compact... but turns out Simulator will still make the compaction blocking so
this change doesn't *really* matter at the moment. I can revert and using the
blocking logic as it doesn't change the test, and leave async compaction for
caleb in a followup patch (which is needed anyways)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
