arjunashok commented on code in PR #231: URL: https://github.com/apache/cassandra-sidecar/pull/231#discussion_r2208321878
########## client-common/src/main/java/org/apache/cassandra/sidecar/common/request/RepairRequest.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.common.request; + +import io.netty.handler.codec.http.HttpMethod; +import org.apache.cassandra.sidecar.common.ApiEndpointsV1; +import org.apache.cassandra.sidecar.common.request.data.RepairPayload; +import org.apache.cassandra.sidecar.common.response.OperationalJobResponse; + +/** + * Class representing the repair API request + */ +public class RepairRequest extends JsonRequest<OperationalJobResponse> +{ + private final RepairPayload repairRequestPayload; + + + /** + * Constructs a Sidecar repair request with the given parameters. + * + * @param keyspace name of the keyspace in the cluster + * @param repairRequestPayload request payload + */ + public RepairRequest(String keyspace, RepairPayload repairRequestPayload) Review Comment: This is a format consistent with how request POJOs are represented in sidecar (eg. `CreateRestoreJobRequest`), where the payload is the actual POST/PUT POJO and the params are the request/URI params - keyspace in this case. It would be redundant to include the keyspace in the payload as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
