belliottsmith commented on code in PR #224:
URL: https://github.com/apache/cassandra-accord/pull/224#discussion_r2210958484
##########
accord-core/src/main/java/accord/coordinate/MaybeRecover.java:
##########
@@ -82,19 +84,26 @@ protected void onDone(Success success, Throwable fail)
// this can be helpful in mitigating flakiness and helping forward
progress for large transactions spanning many shards
if (fail != null)
{
+ if (tracing != null)
Review Comment:
I wondered about this and even briefly flirted with a Tracing.trace static
method for making a single line, but I decided it actually maybe helps to both
be consistent (and not all places would be suitable for a single line) and also
it acts as a kind of comment for the reader so giving it some body/presence
felt positive to me, and I preferred the aesthetic to single lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
